src/heap/incremental-marking.cc - Issue 871253005: Use weak cells in dependent code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/incremental-marking.cc

Issue 871253005: Use weak cells in dependent code. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add comment Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/incremental-marking.cc

diff --git a/src/heap/incremental-marking.cc b/src/heap/incremental-marking.cc

index a85d4a8489326ec84afcd2ca4191d45ebdda18fe..e2c30cdefe67a1f6bf397dde9c10128bdfdb2feb 100644

--- a/src/heap/incremental-marking.cc

+++ b/src/heap/incremental-marking.cc

@@ -550,7 +550,7 @@ void IncrementalMarking::StartMarking(CompactionFlag flag) {

IncrementalMarkingRootMarkingVisitor visitor(this);

heap_->IterateStrongRoots(&visitor, VISIT_ONLY_STRONG);

- heap_->mark_compact_collector()->MarkWeakObjectToCodeTable();

+ heap_->mark_compact_collector()->MarkWeakObjectToCodeTable(&visitor);

// Ready to start incremental marking.

if (FLAG_trace_incremental_marking) {