Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 871253005: Use weak cells in dependent code. (Closed)

Created:
5 years, 11 months ago by ulan
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use weak cells in dependent code. BUG= Committed: https://crrev.com/b79b985988fd3f9e09dcab506da56a9c269e9149 Cr-Commit-Position: refs/heads/master@{#26614}

Patch Set 1 : #

Patch Set 2 : Add comment #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : Address comment and rebase #

Patch Set 5 : Make Heap::weak_object_to_code_table a strong root. #

Patch Set 6 : Rebase #

Total comments: 4

Patch Set 7 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+252 lines, -391 lines) Patch
M include/v8.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 1 2 3 4 5 4 chunks +13 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 2 3 4 5 7 chunks +4 lines, -34 lines 0 comments Download
M src/heap/heap.cc View 1 2 3 4 5 4 chunks +11 lines, -27 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 4 5 6 9 chunks +52 lines, -147 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 3 3 chunks +0 lines, -35 lines 0 comments Download
M src/lithium.cc View 1 2 3 4 3 chunks +7 lines, -4 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 10 chunks +39 lines, -35 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 12 chunks +105 lines, -62 lines 0 comments Download
M src/objects-debug.cc View 1 2 3 4 5 2 chunks +7 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 4 chunks +8 lines, -22 lines 0 comments Download
M src/serialize.cc View 1 2 3 4 5 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
ulan
Hannes, please take a look at mark-compact and object-visiting. Yang, please take a look at ...
5 years, 11 months ago (2015-01-27 13:27:20 UTC) #6
Yang
The non-GC part lgtm. https://codereview.chromium.org/871253005/diff/100001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/871253005/diff/100001/src/objects.cc#newcode11899 src/objects.cc:11899: copy(i, n + count); Can ...
5 years, 11 months ago (2015-01-27 14:43:24 UTC) #7
Hannes Payer (out of office)
lgtm, just one nit https://codereview.chromium.org/871253005/diff/100001/src/heap/mark-compact.h File src/heap/mark-compact.h (left): https://codereview.chromium.org/871253005/diff/100001/src/heap/mark-compact.h#oldcode813 src/heap/mark-compact.h:813: Please remove the definitions below.
5 years, 10 months ago (2015-01-29 21:28:37 UTC) #8
ulan
Hannes, could you please take a look at diff between PS4 and PS5?
5 years, 10 months ago (2015-02-12 09:55:41 UTC) #9
Hannes Payer (out of office)
still LGTM, just formatting nits. https://codereview.chromium.org/871253005/diff/180001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/871253005/diff/180001/src/heap/mark-compact.cc#newcode311 src/heap/mark-compact.cc:311: remove one more newline ...
5 years, 10 months ago (2015-02-12 12:19:47 UTC) #10
ulan
https://codereview.chromium.org/871253005/diff/180001/src/heap/mark-compact.cc File src/heap/mark-compact.cc (right): https://codereview.chromium.org/871253005/diff/180001/src/heap/mark-compact.cc#newcode311 src/heap/mark-compact.cc:311: On 2015/02/12 12:19:47, Hannes Payer wrote: > remove one ...
5 years, 10 months ago (2015-02-12 12:55:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871253005/200001
5 years, 10 months ago (2015-02-12 12:56:53 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:200001)
5 years, 10 months ago (2015-02-12 13:21:12 UTC) #15
commit-bot: I haz the power
5 years, 10 months ago (2015-02-12 13:21:34 UTC) #16
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/b79b985988fd3f9e09dcab506da56a9c269e9149
Cr-Commit-Position: refs/heads/master@{#26614}

Powered by Google App Engine
This is Rietveld 408576698