Issue 871203005: Remove ElementFlags system.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 871203005: Remove ElementFlags system. (Closed)

Created:
5 years, 10 months ago by esprehn

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove ElementFlags system. Tab index is the only thing using it now, we can do something more explicit. I also simplified the tab index code a little bit. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f2555d869d10ff015ee1e502fb6f820b45cf90e0

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -57 lines)			Patch
M	sky/engine/core/dom/Element.h	View	3 chunks	+0 lines, -13 lines	0 comments	Download
M	sky/engine/core/dom/Element.cpp	View	4 chunks	+7 lines, -33 lines	0 comments	Download
M	sky/engine/core/dom/ElementRareData.h	View	3 chunks	+8 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/NodeRareData.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 10 months ago (2015-01-26 21:29:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f2555d869d10ff015ee1e502fb6f820b45cf90e0 (presubmit successful).