Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 871123002: Fix {virtual,override,final} build failures on official CrOS build. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
Glenn Wilson
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix {virtual,override,final} build failures on official CrOS build. BUG=417463 TBR=gwilson@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1b56b0269b2c28613d171c1bf5007e08c217fe78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -28 lines) Patch
M rlz/chromeos/lib/rlz_value_store_chromeos.h View 1 chunk +25 lines, -28 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
TBRing to get the build fixed.
5 years, 11 months ago (2015-01-24 03:14:23 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1b56b0269b2c28613d171c1bf5007e08c217fe78 Cr-Commit-Position: refs/heads/master@{#313000}
5 years, 11 months ago (2015-01-24 03:16:31 UTC) #3
dcheng
5 years, 11 months ago (2015-01-24 03:16:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1b56b0269b2c28613d171c1bf5007e08c217fe78 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698