Plugin Power Saver: Fix Flash JS usage UMA.

Plugin Power Saver: Fix Flash JS usage UMA.

GetWindowObject() get called during plugin initialization, Ignore that.

BUG=451197
Committed: https://crrev.com/efaff8a1a978fb83f6f12d9e523fbf2c152396a1
Cr-Commit-Position: refs/heads/master@{#313808}

[Lei Zhang, 2015-01-24 00:38:09]

thestig@chromium.org changed reviewers:
+ dmichael@chromium.org, tommycli@chromium.org

[Lei Zhang, 2015-01-24 00:38:09]

This code was added inhttps://codereview.chromium.org/823993005/

[dmichael (off chromium), 2015-01-26 16:47:15]

dmichael@chromium.org changed reviewers:
+ ihf@chromium.org

[dmichael (off chromium), 2015-01-26 16:47:16]

+ihf. I don't know if this might miss some uses of scripting by Flash content.
If ActionScript can only run after initilization is complete, then this patch is
probably a good approach. Otherwise, you might want to count calls instead.

[tommycli, 2015-01-26 17:18:58]

On 2015/01/26 16:47:16, dmichael wrote:
> +ihf. I don't know if this might miss some uses of scripting by Flash content.
> If ActionScript can only run after initilization is complete, then this patch
is
> probably a good approach. Otherwise, you might want to count calls instead.

I'm fairly happy with this. Certainly the old version was blatantly broken. If
this simple approach gets us 80% of the way there, then it "looks good to me".
(I am not owner)

[ilja, 2015-01-27 02:08:09]

It avoids the case that we discussed. I wonder if you tested this to see if
there are non-trivial answers? I just did a quick run with EvalJS and there are
ads that don't use it. Even sound that doesn't use it. But many instances I
tried did to some form of scripting. So, fine with me.

[dmichael (off chromium), 2015-01-29 20:59:24]

forgot about this. lgtm since ilja is fine with it.

[Lei Zhang, 2015-01-29 21:46:34]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2015-01-29 21:47:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/871113003/1

[commit-bot: I haz the power, 2015-01-29 22:32:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-01-29 22:32:58]

Patchset 1 (id:??) landed as
https://crrev.com/efaff8a1a978fb83f6f12d9e523fbf2c152396a1
Cr-Commit-Position: refs/heads/master@{#313808}