Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 871093004: Fix test naming in previous commit. (Closed)

Created:
5 years, 11 months ago by Tom Sepez
Modified:
5 years, 11 months ago
Reviewers:
Bo Xu
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix test naming in previous commit. The embeddertests binary should have source files ending in _embeddertest, not _unittest. TBR=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/fa370ac5cf6472f0ec0c9ecf62d1f9dd20ebfa42

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -24 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/src/fpdf_dataavail_embeddertest.cpp View 0 chunks +-1 lines, --1 lines 0 comments Download
D fpdfsdk/src/fpdf_dataavail_unittest.cpp View 1 chunk +0 lines, -23 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Tom Sepez
5 years, 11 months ago (2015-01-23 23:23:01 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fa370ac5cf6472f0ec0c9ecf62d1f9dd20ebfa42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698