Issue 22188. Verify that none or all execution flows return.

pkg/analysis_server/test/services/refactoring/extract_method_test.dart

Index: pkg/analysis_server/test/services/refactoring/extract_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
index 98de0cab65ed56dd747b35a3e7eba6470ef42afd..952974b75a29247b5cc3e869ecaae9503a655227 100644
--- a/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/extract_method_test.dart
@@ -440,6 +440,23 @@ main() {
             "local variables and return statement.");
   }
 
+  test_bad_statements_return_notAllExecutionFlows() {
+    indexTestUnit('''
+main(int p) {
+// start
+  if (p == 0) {
+    return;
+  }
+// end
+  print(p);
+}
+''');
+    _createRefactoringForStartEndComments();
+    return _assertConditionsError(
+        "Selected statements contain a return statement, but not all possible "

[Paul Berry, 2015/02/10 18:25:16]

Nit: it would be nice to put this string in a const somewhere so that we don't
have to duplicate it between the implementation and the test.

+        "execuion flows end in a return. Semantics may not be preserved.");
+  }
+
   test_bad_switchCase() {
     indexTestUnit('''
 main() {