Source/modules/websockets/DOMWebSocket.cpp - Issue 871013007: Use enum BinaryType for WebSocket.binaryType, instead of DOMString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/DOMWebSocket.cpp

Issue 871013007: Use enum BinaryType for WebSocket.binaryType, instead of DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/attributes.cpp ('K') | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/DOMWebSocket.cpp

diff --git a/Source/modules/websockets/DOMWebSocket.cpp b/Source/modules/websockets/DOMWebSocket.cpp

index 25818985834cfb23185f818b536a235c33734906..8847a69e8463ef788f296d30163b3a56917b5e38 100644

--- a/Source/modules/websockets/DOMWebSocket.cpp

+++ b/Source/modules/websockets/DOMWebSocket.cpp

@@ -529,7 +529,7 @@ void DOMWebSocket::setBinaryType(const String& binaryType)

m_binaryType = BinaryTypeArrayBuffer;

return;

}

- logError("'" + binaryType + "' is not a valid value for binaryType; binaryType remains unchanged.");

+ ASSERT_NOT_REACHED();

Nils Barth (inactive) 2015/02/11 18:58:45 ASSERT sounds fine, thanks!

}

const AtomicString& DOMWebSocket::interfaceName() const

« Source/bindings/templates/attributes.cpp ('K') | « Source/bindings/tests/results/core/V8TestObject.cpp ('k') | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »