Chromium Code Reviews

Side by Side Diff: Source/modules/websockets/DOMWebSocketTest.cpp

Issue 871013007: Use enum BinaryType for WebSocket.binaryType, instead of DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « Source/modules/websockets/DOMWebSocket.cpp ('k') | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/websockets/DOMWebSocket.h" 6 #include "modules/websockets/DOMWebSocket.h"
7 7
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8BindingForTesting.h" 10 #include "bindings/core/v8/V8BindingForTesting.h"
(...skipping 648 matching lines...)
659 // We can't create a Blob because the blob registration cannot be mocked yet. 659 // We can't create a Blob because the blob registration cannot be mocked yet.
660 660
661 // FIXME: We should add tests for bufferedAmount. 661 // FIXME: We should add tests for bufferedAmount.
662 662
663 // FIXME: We should add tests for data receiving. 663 // FIXME: We should add tests for data receiving.
664 664
665 TEST_F(DOMWebSocketTest, binaryType) 665 TEST_F(DOMWebSocketTest, binaryType)
666 { 666 {
667 EXPECT_EQ("blob", m_websocket->binaryType()); 667 EXPECT_EQ("blob", m_websocket->binaryType());
668 668
669 m_websocket->setBinaryType("hoge");
670
671 EXPECT_EQ("blob", m_websocket->binaryType());
672
673 m_websocket->setBinaryType("arraybuffer"); 669 m_websocket->setBinaryType("arraybuffer");
674 670
675 EXPECT_EQ("arraybuffer", m_websocket->binaryType()); 671 EXPECT_EQ("arraybuffer", m_websocket->binaryType());
676 672
677 m_websocket->setBinaryType("fuga");
678
679 EXPECT_EQ("arraybuffer", m_websocket->binaryType());
680
681 m_websocket->setBinaryType("blob"); 673 m_websocket->setBinaryType("blob");
682 674
683 EXPECT_EQ("blob", m_websocket->binaryType()); 675 EXPECT_EQ("blob", m_websocket->binaryType());
684 } 676 }
685 677
678 class DOMWebSocketDeathTest : public DOMWebSocketTestBase, public ::testing::Tes t {
679 public:
680 };
681
682 TEST_F(DOMWebSocketDeathTest, binaryType)
683 {
684 m_websocket->setBinaryType("arraybuffer");
685
686 EXPECT_EQ("arraybuffer", m_websocket->binaryType());
687 EXPECT_DEATH(m_websocket->setBinaryType("hoge"), "");
688 EXPECT_EQ("arraybuffer", m_websocket->binaryType());
689 }
690
686 // FIXME: We should add tests for suspend / resume. 691 // FIXME: We should add tests for suspend / resume.
687 692
688 class DOMWebSocketValidClosingTest : public DOMWebSocketTestBase, public ::testi ng::TestWithParam<unsigned short> { 693 class DOMWebSocketValidClosingTest : public DOMWebSocketTestBase, public ::testi ng::TestWithParam<unsigned short> {
689 public: 694 public:
690 }; 695 };
691 696
692 TEST_P(DOMWebSocketValidClosingTest, test) 697 TEST_P(DOMWebSocketValidClosingTest, test)
693 { 698 {
694 { 699 {
695 InSequence s; 700 InSequence s;
(...skipping 34 matching lines...)
730 EXPECT_EQ(InvalidAccessError, m_exceptionState.code()); 735 EXPECT_EQ(InvalidAccessError, m_exceptionState.code());
731 EXPECT_EQ(String::format("The code must be either 1000, or between 3000 and 4999. %d is neither.", GetParam()), m_exceptionState.message()); 736 EXPECT_EQ(String::format("The code must be either 1000, or between 3000 and 4999. %d is neither.", GetParam()), m_exceptionState.message());
732 EXPECT_EQ(DOMWebSocket::CONNECTING, m_websocket->readyState()); 737 EXPECT_EQ(DOMWebSocket::CONNECTING, m_websocket->readyState());
733 } 738 }
734 739
735 INSTANTIATE_TEST_CASE_P(DOMWebSocketInvalidClosingCode, DOMWebSocketInvalidClosi ngCodeTest, ::testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535)); 740 INSTANTIATE_TEST_CASE_P(DOMWebSocketInvalidClosingCode, DOMWebSocketInvalidClosi ngCodeTest, ::testing::Values(0, 1, 998, 999, 1001, 2999, 5000, 9999, 65535));
736 741
737 } // namespace 742 } // namespace
738 743
739 } // namespace blink 744 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/websockets/DOMWebSocket.cpp ('k') | Source/modules/websockets/WebSocket.idl » ('j') | no next file with comments »

Powered by Google App Engine