Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1982)

Unified Diff: chrome/browser/sessions/better_session_restore_browsertest.cc

Issue 871013006: Use callbacks in SessionRestore unit tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add destructor Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sessions/better_session_restore_browsertest.cc
diff --git a/chrome/browser/sessions/better_session_restore_browsertest.cc b/chrome/browser/sessions/better_session_restore_browsertest.cc
index 47997f7844f4d7b56ab237500a5b9b9f20627520..b6c902602705912c394a4dfe3bd2a2f7ec7deb59 100644
--- a/chrome/browser/sessions/better_session_restore_browsertest.cc
+++ b/chrome/browser/sessions/better_session_restore_browsertest.cc
@@ -20,6 +20,7 @@
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_impl.h"
#include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/sessions/session_restore_test_helper.h"
#include "chrome/browser/sessions/session_service_factory.h"
#include "chrome/browser/sessions/session_service_test_helper.h"
#include "chrome/browser/ui/browser.h"
@@ -377,9 +378,7 @@ class ContinueWhereILeftOffTest : public BetterSessionRestoreTest {
protected:
Browser* QuitBrowserAndRestore(Browser* browser,
bool close_all_windows) override {
- content::WindowedNotificationObserver session_restore_observer(
- chrome::NOTIFICATION_SESSION_RESTORE_DONE,
- content::NotificationService::AllSources());
+ SessionRestoreTestHelper session_restore_observer;
Browser* new_browser = BetterSessionRestoreTest::QuitBrowserAndRestore(
browser, close_all_windows);
session_restore_observer.Wait();
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/browser/sessions/session_restore_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698