Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 871013005: Notify ProgrammaticScrollAnimator about scroll layer destruction (Closed)

Created:
5 years, 11 months ago by ajuma
Modified:
5 years, 11 months ago
Reviewers:
Ian Vollick
CC:
blink-reviews, kenneth.christiansen, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-layers+watch_chromium.org, dstockwell, Timothy Loh, darktears, Steve Block, Eric Willigers
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Notify ProgrammaticScrollAnimator about scroll layer destruction This makes ProgrammaticScrollAnimator get notified whenever a composited scroll layer is created or destroyed, allowing ProgrammaticScrollAnimator to take over scroll animations from destroyed composited scroll layers. BUG=243871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -0 lines) Patch
A LayoutTests/fast/scroll-behavior/overflow-scroll-loses-composited-scrolling.html View 1 chunk +58 lines, -0 lines 0 comments Download
A LayoutTests/fast/scroll-behavior/overflow-scroll-loses-composited-scrolling-expected.txt View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/scroll/ProgrammaticScrollAnimator.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollableArea.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
ajuma
5 years, 11 months ago (2015-01-23 20:01:43 UTC) #2
Ian Vollick
On 2015/01/23 20:01:43, ajuma wrote: Nice. LGTM. Lovely test.
5 years, 11 months ago (2015-01-24 01:59:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871013005/1
5 years, 11 months ago (2015-01-24 02:00:03 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 02:03:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188918

Powered by Google App Engine
This is Rietveld 408576698