Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 871013004: Don't do auto-enrollment if the write protect switch is off. (Closed)

Created:
5 years, 11 months ago by Mattias Nissler (ping if slow)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gperftools_prof_timer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't do auto-enrollment if the write protect switch is off. Rationale is that disengaged write protect switch indicates the user already has control over firmware and VPD contents, trying to force enrollment in this environment doesn't make sense. BUG=chromium:450325 Committed: https://crrev.com/526c424a5ef720b6bcbbd05451477344044a3334 Cr-Commit-Position: refs/heads/master@{#313110}

Patch Set 1 #

Patch Set 2 : Fix mistake in test adjustment. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc View 1 chunk +10 lines, -1 line 2 comments Download
M chrome/browser/chromeos/policy/device_status_collector.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/device_status_collector_browsertest.cc View 1 2 chunks +13 lines, -5 lines 0 comments Download
M chromeos/system/statistics_provider.h View 2 chunks +8 lines, -1 line 0 comments Download
M chromeos/system/statistics_provider.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Mattias Nissler (ping if slow)
Please review: derat@: statistics provider bits bartfab@: policy bits
5 years, 11 months ago (2015-01-23 16:26:48 UTC) #2
Daniel Erat
lgtm for chromeos/
5 years, 11 months ago (2015-01-23 16:30:23 UTC) #3
bartfab (slow)
lgtm https://codereview.chromium.org/871013004/diff/20001/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc (right): https://codereview.chromium.org/871013004/diff/20001/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc#newcode90 chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:90: std::string write_protect_switch_boot; Nit: Maybe s/boot/on_boot/? The name does ...
5 years, 11 months ago (2015-01-26 15:48:55 UTC) #4
Mattias Nissler (ping if slow)
https://codereview.chromium.org/871013004/diff/20001/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc File chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc (right): https://codereview.chromium.org/871013004/diff/20001/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc#newcode90 chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc:90: std::string write_protect_switch_boot; On 2015/01/26 15:48:55, bartfab wrote: > Nit: ...
5 years, 11 months ago (2015-01-26 20:08:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/871013004/20001
5 years, 11 months ago (2015-01-26 20:10:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-26 20:15:58 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 20:17:03 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/526c424a5ef720b6bcbbd05451477344044a3334
Cr-Commit-Position: refs/heads/master@{#313110}

Powered by Google App Engine
This is Rietveld 408576698