Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: components/nacl/renderer/ppb_nacl_private_impl.cc

Issue 870923004: NaCl: Remove now-unneeded SRPC reverse service code (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/api/private/ppb_nacl_private.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/renderer/ppb_nacl_private_impl.cc
diff --git a/components/nacl/renderer/ppb_nacl_private_impl.cc b/components/nacl/renderer/ppb_nacl_private_impl.cc
index 19fcf26b36bd3093808654b45cf208363a931166..61787b920767a29be1d89bc3d7d5d70b7ac8a49c 100644
--- a/components/nacl/renderer/ppb_nacl_private_impl.cc
+++ b/components/nacl/renderer/ppb_nacl_private_impl.cc
@@ -1462,39 +1462,6 @@ void LogTranslateTime(const char* histogram_name,
time_in_us / 1000));
}
-void DidOpenManifestEntry(PP_NaClFileInfo* out_file_info,
- PP_CompletionCallback callback,
- int32_t pp_error,
- const PP_NaClFileInfo& file_info) {
- if (pp_error == PP_OK)
- *out_file_info = file_info;
- callback.func(callback.user_data, pp_error);
-}
-
-void OpenManifestEntry(PP_Instance instance,
- PP_Bool is_helper_process,
- const char* key,
- PP_NaClFileInfo* out_file_info,
- PP_CompletionCallback callback) {
- std::string url;
- PP_PNaClOptions pnacl_options;
- pnacl_options.translate = PP_FALSE;
- pnacl_options.is_debug = PP_FALSE;
- pnacl_options.opt_level = 2;
- if (!ManifestResolveKey(instance,
- PP_ToBool(is_helper_process),
- key,
- &url,
- &pnacl_options)) {
- PostPPCompletionCallback(callback, PP_ERROR_FAILED);
- }
-
- // TODO(teravest): Make a type like PP_NaClFileInfo to use for DownloadFile
- // that would close the file handle on destruction.
- DownloadFile(instance, url,
- base::Bind(&DidOpenManifestEntry, out_file_info, callback));
-}
-
void SetPNaClStartTime(PP_Instance instance) {
NexeLoadManager* load_manager = GetNexeLoadManager(instance);
if (load_manager)
@@ -1694,7 +1661,6 @@ const PPB_NaCl_Private nacl_interface = {
&DownloadNexe,
&ReportSelLdrStatus,
&LogTranslateTime,
- &OpenManifestEntry,
&SetPNaClStartTime,
&StreamPexe
};
« no previous file with comments | « no previous file | ppapi/api/private/ppb_nacl_private.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698