Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 870923004: NaCl: Remove now-unneeded SRPC reverse service code (Closed)

Created:
5 years, 11 months ago by Mark Seaborn
Modified:
5 years, 11 months ago
Reviewers:
teravest
CC:
chromium-reviews, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, nfullagar1, piman+watch_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Remove now-unneeded SRPC reverse service code The last active use of PluginReverseInterface was via its StartupInitializationComplete()/"init_done" method, but recent cleanups have made that into a no-op. We can therefore remove PluginReverseInterface. We no longer need to call NaCl's "reverse_setup" SRPC call. This removes the Chromium-side parts of the old SRPC-based open_resource() implementation, which was no longer called. This allows us to remove OpenManifestEntry() from PPB_NaCl_Private. Add some #includes to fix include-what-you-use problems that become apparent after removing code. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=NaCl tests in browser_tests Committed: https://crrev.com/99fa53e6d838abd24d690a748b09b03420dfc1ce Cr-Commit-Position: refs/heads/master@{#312953}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -648 lines) Patch
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 2 chunks +0 lines, -34 lines 0 comments Download
M ppapi/api/private/ppb_nacl_private.idl View 1 1 chunk +0 lines, -11 lines 0 comments Download
M ppapi/c/private/ppb_nacl_private.h View 1 2 chunks +1 line, -11 lines 0 comments Download
M ppapi/native_client/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/native_client.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/nacl_subprocess.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_coordinator.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/pnacl_translate_thread.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.h View 1 4 chunks +1 line, -77 lines 0 comments Download
M ppapi/native_client/src/trusted/plugin/service_runtime.cc View 1 7 chunks +0 lines, -251 lines 0 comments Download
D ppapi/native_client/src/trusted/weak_ref/call_on_main_thread.h View 1 chunk +0 lines, -252 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 11 months ago (2015-01-23 16:57:34 UTC) #2
teravest
lgtm
5 years, 11 months ago (2015-01-23 17:08:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870923004/20001
5 years, 11 months ago (2015-01-23 22:40:19 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 22:50:57 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:52:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/99fa53e6d838abd24d690a748b09b03420dfc1ce
Cr-Commit-Position: refs/heads/master@{#312953}

Powered by Google App Engine
This is Rietveld 408576698