Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 870923003: Push version and changelog as a separate commit. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Push version and changelog as a separate commit. BUG=chromium:451357 LOG=n TBR=tandrii@chromium.org NOTRY=true Committed: https://crrev.com/ade95b74c747c7298f9ee15470755ad46dbcc156 Cr-Commit-Position: refs/heads/master@{#26251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -16 lines) Patch
M tools/push-to-trunk/push_to_trunk.py View 3 chunks +29 lines, -4 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 3 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-23 13:43:49 UTC) #2
tandrii(chromium)
lgtm The "TRUNKBRANCH" key is confusing, though.
5 years, 11 months ago (2015-01-23 14:46:29 UTC) #3
Michael Achenbach
Will make a naming cleanup in some extra commit.
5 years, 11 months ago (2015-01-23 14:57:51 UTC) #4
Michael Achenbach
Will make a naming cleanup in some extra commit.
5 years, 11 months ago (2015-01-23 14:57:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870923003/1
5 years, 11 months ago (2015-01-23 14:58:39 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 14:58:56 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 14:59:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ade95b74c747c7298f9ee15470755ad46dbcc156
Cr-Commit-Position: refs/heads/master@{#26251}

Powered by Google App Engine
This is Rietveld 408576698