Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870913003: Fix Widows GN build of components/metrics. (Closed)

Created:
5 years, 11 months ago by Slava Chigrin
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Widows GN build of components/metrics. Committed: https://crrev.com/9d761c02fcf1f2a821e7c43d1fdb25f61eeadea1 Cr-Commit-Position: refs/heads/master@{#312941}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M components/metrics/BUILD.gn View 1 chunk +4 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Slava Chigrin
https://codereview.chromium.org/870913003/diff/1/components/metrics/BUILD.gn File components/metrics/BUILD.gn (right): https://codereview.chromium.org/870913003/diff/1/components/metrics/BUILD.gn#newcode69 components/metrics/BUILD.gn:69: sources -= [ "machine_id_provider_stub.cc" ] Same as in GYP ...
5 years, 11 months ago (2015-01-23 21:05:41 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 11 months ago (2015-01-23 21:09:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870913003/1
5 years, 11 months ago (2015-01-23 21:10:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 22:01:49 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:04:13 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9d761c02fcf1f2a821e7c43d1fdb25f61eeadea1
Cr-Commit-Position: refs/heads/master@{#312941}

Powered by Google App Engine
This is Rietveld 408576698