Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870903003: Refactor version increment in release scripts. (Closed)

Created:
5 years, 11 months ago by Michael Achenbach
Modified:
5 years, 11 months ago
Reviewers:
tandrii(chromium)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Refactor version increment in release scripts. BUG=chromium:451975 TBR=tandrii@chromium.org NOTRY=true LOG=n Committed: https://crrev.com/3c17b3b3695aa329daa2a5bc6d1867e6e9daab8d Cr-Commit-Position: refs/heads/master@{#26284}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -32 lines) Patch
M tools/release/common_includes.py View 1 2 3 chunks +16 lines, -1 line 1 comment Download
M tools/release/push_to_candidates.py View 1 2 4 chunks +14 lines, -24 lines 0 comments Download
M tools/release/test_scripts.py View 1 2 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 11 months ago (2015-01-27 08:52:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870903003/40001
5 years, 11 months ago (2015-01-27 08:53:20 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-27 08:53:35 UTC) #5
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3c17b3b3695aa329daa2a5bc6d1867e6e9daab8d Cr-Commit-Position: refs/heads/master@{#26284}
5 years, 11 months ago (2015-01-27 08:53:49 UTC) #6
tandrii(chromium)
5 years, 11 months ago (2015-01-27 23:59:28 UTC) #7
Message was sent while issue was closed. 
lgtm

https://codereview.chromium.org/870903003/diff/40001/tools/release/common_inc...
File tools/release/common_includes.py (right):

https://codereview.chromium.org/870903003/diff/40001/tools/release/common_inc...
tools/release/common_includes.py:384: return self._state.get(key)
Are you sure there were no code relying on KeyError being raised here before
this change?

Powered by Google App Engine
This is Rietveld 408576698