Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: content/shell/browser/shell_devtools_frontend.h

Issue 870883008: Test runner: make inspector tests reuse a single inspector process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell.cc ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_devtools_frontend.h
diff --git a/content/shell/browser/shell_devtools_frontend.h b/content/shell/browser/shell_devtools_frontend.h
index 038b88bff932bea231ce395f9771a53943364c05..adfe90e7d46b90377fba1ad3db5b9df3ecf38681 100644
--- a/content/shell/browser/shell_devtools_frontend.h
+++ b/content/shell/browser/shell_devtools_frontend.h
@@ -30,15 +30,26 @@ class ShellDevToolsFrontend : public WebContentsObserver,
void InspectElementAt(int x, int y);
void Close();
+ void DisconnectFromTarget();
+
Shell* frontend_shell() const { return frontend_shell_; }
protected:
ShellDevToolsFrontend(Shell* frontend_shell, DevToolsAgentHost* agent_host);
~ShellDevToolsFrontend() override;
+ // content::DevToolsAgentHostClient implementation.
+ void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;
+ void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
+ const std::string& message) override;
+ void AttachTo(WebContents* inspected_contents);
+
private:
// WebContentsObserver overrides
void RenderViewCreated(RenderViewHost* render_view_host) override;
+ void DidNavigateMainFrame(
+ const LoadCommittedDetails& details,
+ const FrameNavigateParams& params) override;
void WebContentsDestroyed() override;
// content::DevToolsFrontendHost::Delegate implementation.
@@ -46,11 +57,6 @@ class ShellDevToolsFrontend : public WebContentsObserver,
void HandleMessageFromDevToolsFrontendToBackend(
const std::string& message) override;
- // content::DevToolsAgentHostClient implementation.
- void DispatchProtocolMessage(DevToolsAgentHost* agent_host,
- const std::string& message) override;
- void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override;
-
Shell* frontend_shell_;
scoped_refptr<DevToolsAgentHost> agent_host_;
scoped_ptr<DevToolsFrontendHost> frontend_host_;
« no previous file with comments | « content/shell/browser/shell.cc ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698