Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: content/shell/browser/layout_test/layout_test_devtools_frontend.cc

Issue 870883008: Test runner: make inspector tests reuse a single inspector process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/layout_test/layout_test_devtools_frontend.h ('k') | content/shell/browser/shell.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/layout_test/layout_test_devtools_frontend.cc
diff --git a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
index c8941c616bfc799e4350cc95bd752c2dcb6ba6f0..a9c1af339010e2909ad51d86fd8ed8b32a2f96b5 100644
--- a/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
+++ b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
@@ -33,15 +33,6 @@ LayoutTestDevToolsFrontend* LayoutTestDevToolsFrontend::Show(
return devtools_frontend;
}
-LayoutTestDevToolsFrontend::LayoutTestDevToolsFrontend(
- Shell* frontend_shell,
- DevToolsAgentHost* agent_host)
- : ShellDevToolsFrontend(frontend_shell, agent_host) {
-}
-
-LayoutTestDevToolsFrontend::~LayoutTestDevToolsFrontend() {
-}
-
// static.
GURL LayoutTestDevToolsFrontend::GetDevToolsPathAsURL(
const std::string& settings,
@@ -70,6 +61,27 @@ GURL LayoutTestDevToolsFrontend::GetDevToolsPathAsURL(
return result;
}
+void LayoutTestDevToolsFrontend::ReuseFrontend(WebContents* inspected_contents,
+ const std::string& settings,
+ const std::string frontend_url) {
+ AttachTo(inspected_contents);
+ frontend_shell()->LoadURL(GetDevToolsPathAsURL(settings, frontend_url));
+}
+
+LayoutTestDevToolsFrontend::LayoutTestDevToolsFrontend(
+ Shell* frontend_shell,
+ DevToolsAgentHost* agent_host)
+ : ShellDevToolsFrontend(frontend_shell, agent_host) {
+}
+
+LayoutTestDevToolsFrontend::~LayoutTestDevToolsFrontend() {
+}
+
+void LayoutTestDevToolsFrontend::AgentHostClosed(
+ DevToolsAgentHost* agent_host, bool replaced) {
+ // Do not close the front-end shell.
+}
+
void LayoutTestDevToolsFrontend::RenderProcessGone(
base::TerminationStatus status) {
WebKitTestController::Get()->DevToolsProcessCrashed();
« no previous file with comments | « content/shell/browser/layout_test/layout_test_devtools_frontend.h ('k') | content/shell/browser/shell.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698