Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870883008: Test runner: make inspector tests reuse a single inspector process. (Closed)

Created:
5 years, 10 months ago by pfeldman
Modified:
5 years, 10 months ago
CC:
aandrey+blink_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, paulirish+reviews_chromium.org, pfeldman, vsevik, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test runner: make inspector tests reuse a single inspector process. BUG=454481 Committed: https://crrev.com/55275645a40bc573db434edcc0e6553e75d0258c Cr-Commit-Position: refs/heads/master@{#314358}

Patch Set 1 #

Total comments: 2

Patch Set 2 : review comment addressed. #

Patch Set 3 : for bots #

Patch Set 4 : for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -43 lines) Patch
M content/shell/browser/layout_test/layout_test_devtools_frontend.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_devtools_frontend.cc View 1 2 3 2 chunks +21 lines, -9 lines 0 comments Download
M content/shell/browser/shell.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/shell/browser/shell.cc View 2 chunks +4 lines, -16 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.h View 1 2 3 2 chunks +11 lines, -5 lines 0 comments Download
M content/shell/browser/shell_devtools_frontend.cc View 1 2 3 4 chunks +27 lines, -4 lines 0 comments Download
M content/shell/browser/webkit_test_controller.h View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M content/shell/browser/webkit_test_controller.cc View 1 2 3 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
pfeldman
This change reuses devtools frontend's webcontents across tests. It makes tests run slightly faster on ...
5 years, 10 months ago (2015-02-03 10:58:15 UTC) #2
jochen (gone - plz use gerrit)
that looks great! What happens if the inspector process crashes? Can we produce a similar ...
5 years, 10 months ago (2015-02-03 11:28:35 UTC) #3
pfeldman
The crash output is already there: https://code.google.com/p/chromium/codesearch#chromium/src/content/shell/browser/webkit_test_controller.cc&l=435 https://codereview.chromium.org/870883008/diff/1/content/shell/browser/shell_devtools_frontend.cc File content/shell/browser/shell_devtools_frontend.cc (right): https://codereview.chromium.org/870883008/diff/1/content/shell/browser/shell_devtools_frontend.cc#newcode8 content/shell/browser/shell_devtools_frontend.cc:8: #include "base/debug/stack_trace.h" ...
5 years, 10 months ago (2015-02-03 11:34:38 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-03 11:36:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870883008/60001
5 years, 10 months ago (2015-02-03 16:56:10 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-03 17:33:33 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 17:34:21 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/55275645a40bc573db434edcc0e6553e75d0258c
Cr-Commit-Position: refs/heads/master@{#314358}

Powered by Google App Engine
This is Rietveld 408576698