Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 870873002: Add CAST_PRODUCT_TYPE_AUDIO to cast metrics proto (Closed)

Created:
5 years, 11 months ago by cleichner
Modified:
5 years, 11 months ago
Reviewers:
gfhuang, Mark P
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CAST_PRODUCT_TYPE_AUDIO to cast metrics proto BUG= Committed: https://crrev.com/55fba46bc691d512bc8070a3f55eee8a436e0bfd Cr-Commit-Position: refs/heads/master@{#312870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/metrics/proto/cast_logs.proto View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
cleichner
5 years, 11 months ago (2015-01-23 01:16:21 UTC) #4
gfhuang
lgtm
5 years, 11 months ago (2015-01-23 01:17:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870873002/1
5 years, 11 months ago (2015-01-23 01:20:24 UTC) #6
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 11 months ago (2015-01-23 01:20:27 UTC) #8
Mark P
lgtm
5 years, 11 months ago (2015-01-23 01:24:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870873002/1
5 years, 11 months ago (2015-01-23 16:46:55 UTC) #12
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
5 years, 11 months ago (2015-01-23 16:46:58 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870873002/1
5 years, 11 months ago (2015-01-23 16:48:36 UTC) #18
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary files are still unsupported ...
5 years, 11 months ago (2015-01-23 17:42:37 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870873002/1
5 years, 11 months ago (2015-01-23 17:43:55 UTC) #23
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 17:45:20 UTC) #24
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 17:46:55 UTC) #25
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55fba46bc691d512bc8070a3f55eee8a436e0bfd
Cr-Commit-Position: refs/heads/master@{#312870}

Powered by Google App Engine
This is Rietveld 408576698