Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 870863003: Filter out a few more files from NaCl build of base/ (Closed)

Created:
5 years, 11 months ago by jvoung (off chromium)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Filter out a few more files from NaCl build of base/ Some files like important_file_writer, and stack_trace will fail to link if they are ever linked in, because what they depend on has already been filtered out (file_util, file_util_posix and stack_trace_posix). Others just don't seem necessary (parts of base/process/). This helps a little w/ an upcoming pnacl LLVM 3.6 merge, but doesn't fully solve a linking problem. Otherwise it's fewer files to build w/ a NaCl compiler. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4026 Committed: https://crrev.com/8227220d20b31c22740a73e8466e65157950b020 Cr-Commit-Position: refs/heads/master@{#312852}

Patch Set 1 #

Patch Set 2 : Revert histogram. Used by remoting / libnet. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/base.gypi View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jvoung (off chromium)
5 years, 11 months ago (2015-01-23 03:51:58 UTC) #3
Mark Seaborn
LGTM
5 years, 11 months ago (2015-01-23 04:08:29 UTC) #4
Mark Mentovai
LGTM
5 years, 11 months ago (2015-01-23 04:38:29 UTC) #5
bbudge
lgtm
5 years, 11 months ago (2015-01-23 13:13:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870863003/20001
5 years, 11 months ago (2015-01-23 15:47:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 15:51:37 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 15:52:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8227220d20b31c22740a73e8466e65157950b020
Cr-Commit-Position: refs/heads/master@{#312852}

Powered by Google App Engine
This is Rietveld 408576698