content/browser/web_contents/web_contents_impl.cc - Issue 870833002: [android] Autofill popup behavior fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index ff003ddb3c808f2ecd7ce45abb86207620d9d2bd..b74d64c056e9b8abd7534f14932740f3ad603dc4 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1339,12 +1339,14 @@ void WebContentsImpl::RenderWidgetGotFocus(

}

void WebContentsImpl::RenderWidgetWasResized(

- RenderWidgetHostImpl* render_widget_host) {

+ RenderWidgetHostImpl* render_widget_host,

+ bool width_changed) {

RenderFrameHostImpl* rfh = static_cast<RenderFrameHostImpl*>(GetMainFrame());

if (!rfh || render_widget_host != rfh->GetRenderWidgetHost())

return;

- FOR_EACH_OBSERVER(WebContentsObserver, observers_, MainFrameWasResized());

+ FOR_EACH_OBSERVER(WebContentsObserver, observers_,

+ MainFrameWasResized(width_changed));

}

bool WebContentsImpl::PreHandleKeyboardEvent(