chrome/browser/ui/views/autofill/autofill_popup_view_views.h - Issue 870833002: [android] Autofill popup behavior fixes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_popup_view_views.h

Issue 870833002: [android] Autofill popup behavior fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update expectations of old test and add a new test. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/autofill/autofill_popup_view_views.h

diff --git a/chrome/browser/ui/views/autofill/autofill_popup_view_views.h b/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

index cd2d95e35dd307ef4860cdbcd5b481b7962013a6..e7f09b577bb8f66a613e9784a313b69e0cf9fb85 100644

--- a/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

+++ b/chrome/browser/ui/views/autofill/autofill_popup_view_views.h

@@ -16,11 +16,8 @@ namespace autofill {

class AutofillPopupViewViews : public AutofillPopupBaseView,

public AutofillPopupView {

public:

- // The observing widget should be the top level widget for the native

- // view, which we need to listen to for several signals that indicate the

- // popup should be closed.

AutofillPopupViewViews(AutofillPopupController* controller,

- views::Widget* observing_widget);

+ views::FocusManager* focus_manager);

private:

~AutofillPopupViewViews() override;