[android] Autofill popup behavior fixes.

chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
@@ skipping 78 matching lines @@
   }
 
   // Normally the WebContents will automatically delete the delegate, but here
   // the delegate is owned by this test, so we have to manually destroy.
   void WebContentsDestroyed() override { autofill_external_delegate_.reset(); }
 
  protected:
   scoped_ptr<TestAutofillExternalDelegate> autofill_external_delegate_;
 };
 
-// Autofill UI isn't currently hidden on window move on Mac.
-// http://crbug.com/180566
-#if !defined(OS_MACOSX)
 IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,
-                       HidePopupOnWindowConfiguration) {
+                       HidePopupOnWindowResize) {
   GenerateTestAutofillPopup(autofill_external_delegate_.get());
 
   EXPECT_FALSE(autofill_external_delegate_->popup_hidden());
 
   // Resize the window, which should cause the popup to hide.
-  gfx::Rect new_bounds = browser()->window()->GetBounds() - gfx::Vector2d(1, 1);
+  gfx::Rect new_bounds = browser()->window()->GetBounds();

[Evan Stade, 2015/01/26 20:21:54]

seems like you should leave this test as is (perhaps change expectations to
reflect new expected behavior) and add another test for the resize behavior

[please use gerrit instead, 2015/01/26 23:49:03]

Changed expectations and added another test. The two tests are now called
DoNotHidePopupOnWindowMove and HidePopupOnWindowResize.

+  new_bounds.Inset(1, 1);
   browser()->window()->SetBounds(new_bounds);
 
   autofill_external_delegate_->WaitForPopupHidden();
   EXPECT_TRUE(autofill_external_delegate_->popup_hidden());
 }
-#endif // !defined(OS_MACOSX)
 
 // This test checks that the browser doesn't crash if the delegate is deleted
 // before the popup is hidden.
 IN_PROC_BROWSER_TEST_F(AutofillPopupControllerBrowserTest,
                        DeleteDelegateBeforePopupHidden){
   GenerateTestAutofillPopup(autofill_external_delegate_.get());
 
   // Delete the external delegate here so that is gets deleted before popup is
   // hidden. This can happen if the web_contents are destroyed before the popup
   // is hidden. See http://crbug.com/232475
   autofill_external_delegate_.reset();
 }
 
 }  // namespace autofill