Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870823002: Fix assert in remoting.XmppConnection (Closed)

Created:
5 years, 11 months ago by Sergey Ulanov
Modified:
5 years, 11 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M remoting/webapp/crd/js/xmpp_connection.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
Sergey Ulanov
5 years, 11 months ago (2015-01-22 23:47:46 UTC) #2
kelvinp
lgtm
5 years, 11 months ago (2015-01-22 23:52:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870823002/1
5 years, 11 months ago (2015-01-22 23:55:44 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 01:58:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870823002/1
5 years, 11 months ago (2015-01-23 17:57:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/114010)
5 years, 11 months ago (2015-01-23 17:58:02 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4807126be05ff94f172c3394ce03493bcaf6e9f0 Cr-Commit-Position: refs/heads/master@{#312872}
5 years, 11 months ago (2015-01-23 18:00:13 UTC) #12
Sergey Ulanov
5 years, 11 months ago (2015-01-23 18:00:18 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4807126be05ff94f172c3394ce03493bcaf6e9f0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698