Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 870803003: Disabling Sync shouldn't prevent GaiaInfoUpdate. (Closed)

Created:
5 years, 10 months ago by Mike Lerman
Modified:
5 years, 10 months ago
Reviewers:
noms (inactive)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disabling Sync shouldn't prevent GaiaInfoUpdate. Right now --disable-sync disables a lot of signin; any signin errors aren't surfaced, because nothing attempts to ping GAIA. This will help address that. BUG=NONE TEST=Run Chrome with the --disable-sync flag. Sign into a Profile and the name (from G+) should appear in the Avatar Menu. Committed: https://crrev.com/230c8456524162c471e42cc5846a8d74151e2e6a Cr-Commit-Position: refs/heads/master@{#313557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/profiles/gaia_info_update_service.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
noms (inactive)
makes sense. lgtm
5 years, 10 months ago (2015-01-28 18:04:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870803003/1
5 years, 10 months ago (2015-01-28 18:05:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-28 19:07:57 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-28 19:10:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/230c8456524162c471e42cc5846a8d74151e2e6a
Cr-Commit-Position: refs/heads/master@{#313557}

Powered by Google App Engine
This is Rietveld 408576698