Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 870743003: Update {virtual,override,final} to follow C++11 style in media, round 2. (Closed)

Created:
5 years, 11 months ago by dcheng
Modified:
5 years, 11 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update {virtual,override,final} to follow C++11 style in media, round 2. The Google style guide states that only one of {virtual,override,final} should be used for each declaration, since override implies virtual and final implies both virtual and override. This patch was automatically generated with a ChromeOS build using a variation of https://codereview.chromium.org/598073004. BUG=417463 Committed: https://crrev.com/3c3e12faa0908b087303764d76bc99baa8e40183 Cr-Commit-Position: refs/heads/master@{#312798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M media/video/capture/linux/video_capture_device_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M media/video/capture/linux/video_capture_device_chromeos.cc View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
dcheng
5 years, 11 months ago (2015-01-22 22:33:24 UTC) #2
jrummell
lgtm
5 years, 11 months ago (2015-01-23 00:22:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870743003/1
5 years, 11 months ago (2015-01-23 00:26:16 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 02:29:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870743003/1
5 years, 11 months ago (2015-01-23 02:36:19 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/114043)
5 years, 11 months ago (2015-01-23 02:37:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870743003/1
5 years, 11 months ago (2015-01-23 08:41:16 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 08:42:17 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 08:43:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c3e12faa0908b087303764d76bc99baa8e40183
Cr-Commit-Position: refs/heads/master@{#312798}

Powered by Google App Engine
This is Rietveld 408576698