Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: net/quic/quic_ack_notifier_manager.h

Issue 870733002: Change some of QUIC's AckNotifier datastructures from maps to hashmaps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Add_new_RTO_connection_option_84036848
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_ack_notifier_manager.h
diff --git a/net/quic/quic_ack_notifier_manager.h b/net/quic/quic_ack_notifier_manager.h
index 122bda1521f2ee0de2470fcd595f04e1e8909aaf..4fc8b3d5403545dd6537d5e81e5ea56a58865045 100644
--- a/net/quic/quic_ack_notifier_manager.h
+++ b/net/quic/quic_ack_notifier_manager.h
@@ -5,6 +5,7 @@
#ifndef NET_QUIC_QUIC_ACK_NOTIFIER_MANAGER_H_
#define NET_QUIC_QUIC_ACK_NOTIFIER_MANAGER_H_
+#include <list>
#include <map>
#include "base/containers/hash_tables.h"
@@ -45,8 +46,11 @@ class NET_EXPORT_PRIVATE AckNotifierManager {
void OnSerializedPacket(const SerializedPacket& serialized_packet);
private:
+ typedef std::list<QuicAckNotifier*> AckNotifierList;
typedef base::hash_set<QuicAckNotifier*> AckNotifierSet;
- typedef std::map<QuicPacketSequenceNumber, AckNotifierSet> AckNotifierMap;
+ // TODO(ianswett): Further improvement may come from changing this to a deque.
+ typedef base::hash_map<QuicPacketSequenceNumber, AckNotifierList>
+ AckNotifierMap;
// On every ACK frame received by the connection, all the ack_notifiers_ will
// be told which sequeunce numbers were ACKed.
« no previous file with comments | « no previous file | net/quic/quic_ack_notifier_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698