Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 870693003: Fix in-process share group (Closed)

Created:
5 years, 11 months ago by boliu
Modified:
5 years, 11 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix in-process share group GLShareGroup should be the same whenever MailboxManager is the same. So store the GLShareGroup instance in the in-process service. BUG=443464 Committed: https://crrev.com/0ea51acebe39d13d5282899de7f5ba9ba165f187 Cr-Commit-Position: refs/heads/master@{#312954}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
boliu
Another one for ya, although pending testing on all devices.
5 years, 11 months ago (2015-01-22 21:38:59 UTC) #2
boliu
On 2015/01/22 21:38:59, boliu wrote: > Another one for ya, although pending testing on all ...
5 years, 11 months ago (2015-01-23 00:02:14 UTC) #3
no sievers
lgtm
5 years, 11 months ago (2015-01-23 21:33:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870693003/1
5 years, 11 months ago (2015-01-23 21:42:42 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-23 22:51:38 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 22:53:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ea51acebe39d13d5282899de7f5ba9ba165f187
Cr-Commit-Position: refs/heads/master@{#312954}

Powered by Google App Engine
This is Rietveld 408576698