Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: media/base/audio_renderer.h

Issue 870693002: Require Renderer::Initialize() to return a status code via callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Fix comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/renderer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_renderer.h
diff --git a/media/base/audio_renderer.h b/media/base/audio_renderer.h
index 668d919d2a87abcb30eef3380902c257c20992a5..7d0e3d761fad8b5aacddcc566629dc6bcc3fee30 100644
--- a/media/base/audio_renderer.h
+++ b/media/base/audio_renderer.h
@@ -25,7 +25,8 @@ class MEDIA_EXPORT AudioRenderer {
virtual ~AudioRenderer();
// Initialize an AudioRenderer with |stream|, executing |init_cb| upon
- // completion.
+ // completion. If initialization fails, only |init_cb| (not |error_cb|) will
+ // be called.
//
// |set_decryptor_ready_cb| is fired when a Decryptor is needed, i.e. when the
// |stream| is encrypted.
@@ -37,7 +38,7 @@ class MEDIA_EXPORT AudioRenderer {
//
// |ended_cb| is executed when audio rendering has reached the end of stream.
//
- // |error_cb| is executed if an error was encountered.
+ // |error_cb| is executed if an error was encountered after initialization.
virtual void Initialize(DemuxerStream* stream,
const PipelineStatusCB& init_cb,
const SetDecryptorReadyCB& set_decryptor_ready_cb,
« no previous file with comments | « no previous file | media/base/mock_filters.h » ('j') | media/filters/renderer_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698