Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Unified Diff: media/mojo/services/mojo_renderer_service.cc

Issue 870693002: Require Renderer::Initialize() to return a status code via callback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/mojo/services/mojo_renderer_service.cc
diff --git a/media/mojo/services/mojo_renderer_service.cc b/media/mojo/services/mojo_renderer_service.cc
index 562ae1890ecb8e7faee809d2f75768eb5432ea39..8224986584151bb068aeb728536c0729f9641484 100644
--- a/media/mojo/services/mojo_renderer_service.cc
+++ b/media/mojo/services/mojo_renderer_service.cc
@@ -125,9 +125,12 @@ void MojoRendererService::OnStreamReady(const mojo::Closure& callback) {
}
void MojoRendererService::OnRendererInitializeDone(
- const mojo::Closure& callback) {
+ const mojo::Closure& callback, PipelineStatus status) {
DVLOG(1) << __FUNCTION__;
+ if (status != PIPELINE_OK && state_ != STATE_ERROR)
+ OnError(status);
+
if (state_ == STATE_ERROR) {
renderer_.reset();
} else {
« media/filters/renderer_impl.cc ('K') | « media/mojo/services/mojo_renderer_service.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698