Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1465)

Issue 870653006: Revert of Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation (Closed)

Created:
5 years, 10 months ago by Charlie Reis
Modified:
5 years, 10 months ago
Reviewers:
jam, alexmos, nasko
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation (patchset #1 id:1 of https://codereview.chromium.org/905463004/) Reason for revert: Test fixed in https://codereview.chromium.org/904673004/, https://crrev.com/315063. Original issue's description: > Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation > > This test fails within the WebContentsObserverSanityChecker, since no IPC > for RenderFrameCreated is sent. Disable while we find a good way to make > the sanity checker play nicely within the unit test framework running in > --site-per-process > > BUG=417518 > > Committed: https://crrev.com/33e0ed259a19bc6c918fa11fcacffdf709440447 > Cr-Commit-Position: refs/heads/master@{#314960} TBR=alexmos@chromium.org,jam@chromium.org,nasko@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=417518 Committed: https://crrev.com/6d1a88389400427cca73c7c18fb5c178145f2b04 Cr-Commit-Position: refs/heads/master@{#315065}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Created Revert of Disable NavigatorTestWithBrowserSideNavigation.BeginNavigation
5 years, 10 months ago (2015-02-06 18:02:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870653006/1
5 years, 10 months ago (2015-02-06 18:03:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-06 18:04:15 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-06 18:05:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d1a88389400427cca73c7c18fb5c178145f2b04
Cr-Commit-Position: refs/heads/master@{#315065}

Powered by Google App Engine
This is Rietveld 408576698