Chromium Code Reviews| Index: src/IceTargetLowering.h |
| diff --git a/src/IceTargetLowering.h b/src/IceTargetLowering.h |
| index f2e5863b255990720168040bb6940534692751fa..f60812abb75b7116c9b82d8f1d004d9813de6748 100644 |
| --- a/src/IceTargetLowering.h |
| +++ b/src/IceTargetLowering.h |
| @@ -202,8 +202,6 @@ public: |
| virtual void addProlog(CfgNode *Node) = 0; |
| virtual void addEpilog(CfgNode *Node) = 0; |
| - virtual void emitConstants() const = 0; |
| - |
| virtual ~TargetLowering() {} |
| protected: |
| @@ -245,23 +243,22 @@ protected: |
| LoweringContext Context; |
| }; |
| -// TargetGlobalInitLowering is used for "lowering" global |
| -// initializers. It is separated out from TargetLowering because it |
| -// does not require a Cfg. |
| -class TargetGlobalInitLowering { |
| - TargetGlobalInitLowering(const TargetGlobalInitLowering &) = delete; |
| - TargetGlobalInitLowering &operator=(const TargetGlobalInitLowering &) = |
| - delete; |
| +// TargetGlobalLowering is used for "lowering" global initializers, |
| +// including the internal constant pool. It is separated out from |
| +// TargetLowering because it does not require a Cfg. |
| +class TargetGlobalLowering { |
| + TargetGlobalLowering(const TargetGlobalLowering &) = delete; |
| + TargetGlobalLowering &operator=(const TargetGlobalLowering &) = delete; |
|
JF
2015/01/23 17:22:43
TargetGlobalLowering() = delete;
Jim Stichnoth
2015/01/23 21:54:02
Done. (also for TargetGlobalX8632)
|
| public: |
| - static TargetGlobalInitLowering *createLowering(TargetArch Target, |
| - GlobalContext *Ctx); |
| - virtual ~TargetGlobalInitLowering(); |
| + static TargetGlobalLowering *createLowering(GlobalContext *Ctx); |
| + virtual ~TargetGlobalLowering(); |
| - virtual void lower(const VariableDeclaration &Var) = 0; |
| + virtual void lowerInit(const VariableDeclaration &Var) const = 0; |
| + virtual void lowerConstants(GlobalContext *Ctx) const = 0; |
| protected: |
| - TargetGlobalInitLowering(GlobalContext *Ctx) : Ctx(Ctx) {} |
| + TargetGlobalLowering(GlobalContext *Ctx) : Ctx(Ctx) {} |
| GlobalContext *Ctx; |
| }; |