src/PNaClTranslator.h - Issue 870653002: Subzero: Initial implementation of multithreaded translation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/PNaClTranslator.h

Issue 870653002: Subzero: Initial implementation of multithreaded translation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Make CfgQueue::Sequential logic more clear. Move IsEnded field. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/PNaClTranslator.h

diff --git a/src/PNaClTranslator.h b/src/PNaClTranslator.h

index 5738f113e2372f1d678d757b0bc51132eda0575b..e818aaf56a5dc31abc20cfc0055331d546fc7c24 100644

--- a/src/PNaClTranslator.h

+++ b/src/PNaClTranslator.h

@@ -34,8 +34,8 @@ public:

: Translator(Ctx, Flags) {}

// Reads the PNaCl bitcode file and translates to ICE, which is then

- // converted to machine code. Sets ErrorStatus to true if any

- // errors occurred.

+ // converted to machine code. Sets ErrorStatus to 1 if any errors

+ // occurred.

void translate(const std::string &IRFilename);

// Reads MemBuf, assuming it is the PNaCl bitcode contents of IRFilename.

« src/IceGlobalContext.cpp ('K') | « src/IceTranslator.cpp ('k') | src/PNaClTranslator.cpp » ('j') | no next file with comments »