android_run_skia: dump logcat on failure

android_run_skia: dump logcat on failure

logcat -c clears the log before we run.
logcat -d dumps the log stdout and exits.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2d63859f6f3ec237ce28e550e2db554dd492c1e5

[mtklein_C, 2015-01-22 17:56:40]

mtklein@chromium.org changed reviewers:
+ borenet@google.com, djsollen@google.com

[mtklein_C, 2015-01-22 17:56:40]

This will get us stack traces when bots fail.  Seems handy for people too.

[borenet, 2015-01-22 17:59:02]

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_run_skia (right):

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_run_skia:30: /data/local/tmp/skia_launcher
${APP_ARGS[*]}; echo \$? > ${STATUS_FILENAME}"
Why not just "logcat -d" here?

[djsollen, 2015-01-22 18:07:14]

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_run_skia (right):

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_run_skia:30: /data/local/tmp/skia_launcher
${APP_ARGS[*]}; echo \$? > ${STATUS_FILENAME}"
On 2015/01/22 17:59:02, borenet wrote:
> Why not just "logcat -d" here?

agreed

[djsollen, 2015-01-22 18:08:17]

I think this should be a command line option that developers/bots have to opt
into not the default.

[djsollen, 2015-01-22 18:09:50]

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
File platform_tools/android/bin/android_run_skia (right):

https://codereview.chromium.org/870643002/diff/1/platform_tools/android/bin/a...
platform_tools/android/bin/android_run_skia:30: /data/local/tmp/skia_launcher
${APP_ARGS[*]}; echo \$? > ${STATUS_FILENAME}"
On 2015/01/22 18:07:14, djsollen wrote:
> On 2015/01/22 17:59:02, borenet wrote:
> > Why not just "logcat -d" here?
> 
> agreed

I see now that you are just doing this in the failure case which makes more
sense.  So I now ~agree.

[mtklein, 2015-01-22 18:23:04]

On 2015/01/22 18:08:17, djsollen wrote:
> I think this should be a command line option that developers/bots have to opt
> into not the default.

Done.

[djsollen, 2015-01-22 18:28:08]

lgtm

[mtklein, 2015-01-22 18:33:10]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-01-22 18:33:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/870643002/20001

[commit-bot: I haz the power, 2015-01-22 18:43:38]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2d63859f6f3ec237ce28e550e2db554dd492c1e5