Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 870603002: Update asan_device_setup.sh from LLVM r226816. (Closed)

Created:
5 years, 11 months ago by eugenis
Modified:
5 years, 11 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update asan_device_setup.sh from LLVM r226816. BUG=NONE TBR=skyostil@chromium.org NOTRY=true Committed: https://crrev.com/c99a0ce2fb59b8b200fd586dd530b224ed0480e8 Cr-Commit-Position: refs/heads/master@{#312804}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : tbr, notry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -199 lines) Patch
M build/android/pylib/valgrind_tools.py View 1 1 chunk +7 lines, -5 lines 0 comments Download
M tools/android/asan/asan_device_setup.sh View 1 1 chunk +0 lines, -194 lines 0 comments Download
A tools/android/asan/third_party/README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A tools/android/asan/third_party/asan_device_setup.sh View 1 1 chunk +267 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (9 generated)
Evgeniy Stepanov
lgtm
5 years, 11 months ago (2015-01-22 16:30:36 UTC) #2
Evgeniy Stepanov
not lgtm
5 years, 11 months ago (2015-01-22 16:31:12 UTC) #3
Evgeniy Stepanov
This version update might be needed to run ASan on L MR1 devices. It should ...
5 years, 11 months ago (2015-01-22 16:33:21 UTC) #4
Alexander Potapenko
On 2015/01/22 16:33:21, Evgeniy Stepanov wrote: > This version update might be needed to run ...
5 years, 11 months ago (2015-01-23 08:51:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870603002/1
5 years, 11 months ago (2015-01-23 08:58:17 UTC) #7
commit-bot: I haz the power
A disapproval has been posted by following reviewers: eugenis@google.com. Please make sure to get positive ...
5 years, 11 months ago (2015-01-23 08:58:20 UTC) #9
Evgeniy Stepanov
On 2015/01/23 08:51:54, Alexander Potapenko wrote: > On 2015/01/22 16:33:21, Evgeniy Stepanov wrote: > > ...
5 years, 11 months ago (2015-01-23 09:01:07 UTC) #10
Evgeniy Stepanov
lgtm
5 years, 11 months ago (2015-01-23 09:01:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870603002/1
5 years, 11 months ago (2015-01-23 09:02:12 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37869) Try jobs failed on following ...
5 years, 11 months ago (2015-01-23 09:08:16 UTC) #15
Evgeniy Stepanov
On 2015/01/23 09:08:16, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 11 months ago (2015-01-23 09:23:10 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870603002/20001
5 years, 11 months ago (2015-01-23 09:24:08 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/37875)
5 years, 11 months ago (2015-01-23 09:31:37 UTC) #20
Evgeniy Stepanov
Need review for the build/android/pylib change.
5 years, 11 months ago (2015-01-23 09:33:38 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870603002/40001
5 years, 11 months ago (2015-01-23 09:43:19 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 09:44:20 UTC) #25
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/c99a0ce2fb59b8b200fd586dd530b224ed0480e8 Cr-Commit-Position: refs/heads/master@{#312804}
5 years, 11 months ago (2015-01-23 09:45:05 UTC) #26
Sami
5 years, 11 months ago (2015-01-23 10:44:02 UTC) #27
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698