Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Issue 870593003: Componentize expire_history_backend.{cc,h} (Closed)

Created:
5 years, 11 months ago by sdefresne
Modified:
5 years, 11 months ago
Reviewers:
droger
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize expire_history_backend.{cc,h} Move expire_history_backend.{cc,h} into //components/history/core/browser and update .gyp and .gn files. Remove some obsolete code in expire_history_backend_unittest.cc file. BUG=370850 R=droger@google.com Committed: https://crrev.com/2e7702cc2f8385eb3765552601bb82b99584b836 Cr-Commit-Position: refs/heads/master@{#312929}

Patch Set 1 #

Patch Set 2 : Fix a typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -805 lines) Patch
D chrome/browser/history/expire_history_backend.h View 1 chunk +0 lines, -271 lines 0 comments Download
D chrome/browser/history/expire_history_backend.cc View 1 chunk +0 lines, -515 lines 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/history.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/history/core/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/history/core/browser/expire_history_backend.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/history/core/browser/expire_history_backend.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
sdefresne
5 years, 11 months ago (2015-01-22 16:10:36 UTC) #1
droger
lgtm
5 years, 11 months ago (2015-01-22 16:25:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870593003/20001
5 years, 11 months ago (2015-01-22 17:55:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116669) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102469) Try ...
5 years, 11 months ago (2015-01-22 18:49:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870593003/20001
5 years, 11 months ago (2015-01-23 10:12:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/116669) linux_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu_triggered_tests/builds/102469)
5 years, 11 months ago (2015-01-23 10:12:51 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870593003/20001
5 years, 11 months ago (2015-01-23 21:14:00 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-23 21:15:33 UTC) #15
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 21:16:30 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2e7702cc2f8385eb3765552601bb82b99584b836
Cr-Commit-Position: refs/heads/master@{#312929}

Powered by Google App Engine
This is Rietveld 408576698