Exposed mouselock content setting to extensions.

Exposed mouselock content setting to extensions.

BUG=451024
Committed: https://crrev.com/131b6e0f9a048f17960859eb42d33117504e9e54
Cr-Commit-Position: refs/heads/master@{#313060}

[msramek, 2015-01-23 09:11:39]

msramek@chromium.org changed reviewers:
+ mkwst@chromium.org

[msramek, 2015-01-23 09:11:39]

Hi Mike,

tests seem to be green, so please take a look :)

Thanks,
Martin

[Mike West, 2015-01-23 10:15:23]

On 2015/01/23 at 09:11:39, msramek wrote:
> Hi Mike,
> 
> tests seem to be green, so please take a look :)
> 
> Thanks,
> Martin

Will take a look later today. Sorry, in meetings this morning. Again. :/

[Mike West, 2015-01-23 11:23:45]

mkwst@chromium.org changed reviewers:
+ kalman@chromium.org

[Mike West, 2015-01-23 11:23:45]

mkwst@chromium.org changed required reviewers:
+ kalman@chromium.org

[Mike West, 2015-01-23 11:23:46]

Adding kalman@ for OWNERS review (I'm in the OWNERS file for documentation
changes only).

This LGTM % nit (and assuming that you confirmed the primary/secondary URL
behavior).

https://codereview.chromium.org/870573002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/content_settings/content_settings_helpers.cc
(right):

https://codereview.chromium.org/870573002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/content_settings/content_settings_helpers.cc:33:
CONTENT_SETTINGS_NUM_TYPES,
Please add a TODO here to come up with a clever way to assert at compile time
that this array is in sync with the content settings array. This assertion that
we're not jumping off the end of the enum is a good start, but not at all
sufficient.

https://codereview.chromium.org/870573002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/870573002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/content_settings.json:234: "description": "Whether
to allow sites to disable the mouse cursor. One of <br><var>allow</var>: Allow
sites to disable the mouse cursor,<br><var>block</var>: Don't allow sites to
disable the mouse cursor,<br><var>ask</var>: Ask when a site wants to disable
the mouse cursor. <br>Default is <var>ask</var>.<br>The primary URL is the
main-frame URL. The secondary URL is not used.",
Did you verify the behavior of primary/secondary URLs with anyone (Markus or
Bernhard, for example)?

[msramek, 2015-01-23 12:28:48]

Thanks for teaching me the one-line webserver trick :)

https://codereview.chromium.org/870573002/diff/1/chrome/browser/extensions/ap...
File chrome/browser/extensions/api/content_settings/content_settings_helpers.cc
(right):

https://codereview.chromium.org/870573002/diff/1/chrome/browser/extensions/ap...
chrome/browser/extensions/api/content_settings/content_settings_helpers.cc:33:
CONTENT_SETTINGS_NUM_TYPES,
On 2015/01/23 11:23:46, Mike West wrote:
> Please add a TODO here to come up with a clever way to assert at compile time
> that this array is in sync with the content settings array. This assertion
that
> we're not jumping off the end of the enum is a good start, but not at all
> sufficient.

Done.

https://codereview.chromium.org/870573002/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/870573002/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/content_settings.json:234: "description": "Whether
to allow sites to disable the mouse cursor. One of <br><var>allow</var>: Allow
sites to disable the mouse cursor,<br><var>block</var>: Don't allow sites to
disable the mouse cursor,<br><var>ask</var>: Ask when a site wants to disable
the mouse cursor. <br>Default is <var>ask</var>.<br>The primary URL is the
main-frame URL. The secondary URL is not used.",
On 2015/01/23 11:23:46, Mike West wrote:
> Did you verify the behavior of primary/secondary URLs with anyone (Markus or
> Bernhard, for example)?

Verified that the primary url is the main frame on a testing website with an
embedded iframe.

Verified that the secondary url is not used with Markus.

[not at google - send to devlin, 2015-01-23 22:45:13]

lgtm

[msramek, 2015-01-26 09:27:12]

The CQ bit was checked by msramek@chromium.org

[commit-bot: I haz the power, 2015-01-26 09:28:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/870573002/20001

[commit-bot: I haz the power, 2015-01-26 10:40:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-26 10:41:22]

Patchset 2 (id:??) landed as
https://crrev.com/131b6e0f9a048f17960859eb42d33117504e9e54
Cr-Commit-Position: refs/heads/master@{#313060}