mojo/application/content_handler_factory.cc - Issue 870553003: Stop content handled application if delegate returns a null application

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/application/content_handler_factory.cc

Issue 870553003: Stop content handled application if delegate returns a null application (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/application/content_handler_factory.cc

diff --git a/mojo/application/content_handler_factory.cc b/mojo/application/content_handler_factory.cc

index 3ed423ca96e8f2669130ad2c912f0b361680d461..4826ec48e8ac72771a4cff8b5e21363cd38bfa60 100644

--- a/mojo/application/content_handler_factory.cc

+++ b/mojo/application/content_handler_factory.cc

@@ -115,7 +115,8 @@ void ContentHandlerFactory::ManagedDelegate::RunApplication(

URLResponsePtr response) {

base::MessageLoop loop(common::MessagePumpMojo::Create());

auto application = this->CreateApplication(shell.Pass(), response.Pass());

- loop.Run();

+ if (application)

+ loop.Run();

}

void ContentHandlerFactory::Create(ApplicationConnection* connection,

« no previous file with comments | « no previous file | no next file » | no next file with comments »