components/password_manager/core/browser/password_manager.cc - Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated reviews. Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager_unittest.cc ('K') | « components/password_manager/core/browser/password_form_manager_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_manager.cc

diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc

index 0ed1987d18093b7dab2cc0535f72a1107729d4b9..b789a6c5dba13467e3d2fded2ff187b94a3b5cf2 100644

--- a/components/password_manager/core/browser/password_manager.cc

+++ b/components/password_manager/core/browser/password_manager.cc

@@ -236,7 +236,8 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {

if (result == PasswordFormManager::RESULT_NO_MATCH)

continue;

- if ((*iter)->IsIgnorableChangePasswordForm()) {

+ if ((*iter)->IsIgnorableChangePasswordForm(form.username_value,

+ form.password_value)) {

if (logger)

logger->LogMessage(Logger::STRING_CHANGE_PASSWORD_FORM);

continue;