[PasswordManager] Improve detection of ignorable change password forms.

components/password_manager/core/browser/password_form_manager.h

Index: components/password_manager/core/browser/password_form_manager.h
diff --git a/components/password_manager/core/browser/password_form_manager.h b/components/password_manager/core/browser/password_form_manager.h
index ddd113a2f272d53c8b674247fa9b35c8cb85baaa..e8dc6b0358896d8ec4481cf62af3d78fbbc42475 100644
--- a/components/password_manager/core/browser/password_form_manager.h
+++ b/components/password_manager/core/browser/password_form_manager.h
@@ -86,13 +86,16 @@ class PasswordFormManager : public PasswordStoreConsumer {
 
   // Returns true if the observed form has both the current and new password
   // fields, and the username field was not explicitly marked with
-  // autocomplete=username. In these cases it is not clear whether the username
-  // field is the right guess (often such change password forms do not contain
-  // the username at all), and the user should not be bothered with saving a
-  // potentially malformed credential. Once we handle change password forms
-  // correctly, or http://crbug.com/448351 gets implemented, this method should
-  // be replaced accordingly.
-  bool IsIgnorableChangePasswordForm() const;
+  // "autocomplete=username" and the user-typed username and current password
+  // field values do not match to the credentials already stored. In these cases

[vabr (Chromium), 2015/02/23 10:15:26]

grammar nit:
match to the -> match the

[Pritam Nikam, 2015/02/23 11:27:52]

Done.

+  // it is not clear whether the username field is the right guess (often such
+  // change password forms do not contain the username at all), and the user
+  // should not be bothered with saving a potentially malformed credential. Once
+  // we handle change password forms correctly, this method should be replaced
+  // accordingly.
+  bool IsIgnorableChangePasswordForm(
+      const base::string16& typed_username,
+      const base::string16& typed_password) const;
 
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted() const;