Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index be4922c9ad42448492ddba246d1c9f1e81a3dd00..b0daa888123673dfb1f9c635e4d9b9cefde859d2 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -234,12 +234,6 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
if (result == PasswordFormManager::RESULT_NO_MATCH)
continue;
- if ((*iter)->IsIgnorableChangePasswordForm()) {
vabr (Chromium) 2015/02/02 14:22:53 Should you also delete the method, which is no lon
Pritam Nikam 2015/02/05 06:12:07 I'm keeping this as a private function.
- if (logger)
- logger->LogMessage(Logger::STRING_CHANGE_PASSWORD_FORM);
- continue;
- }
-
if (!(*iter)->HasCompletedMatching()) {
has_found_matching_managers_which_were_not_ready = true;
continue;
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698