[PasswordManager] Improve detection of ignorable change password forms.

components/password_manager/core/browser/password_form_manager.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 #define COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 68 matching lines @@
   // PasswordManager::ProvisionallySave, which would interact with this object
   // before the db has had time to answer with matching password entries.
   // This is intended to be a one-time check; if the return value is false the
   // expectation is caller will give up. This clearly won't work if you put it
   // in a loop and wait for matching to complete; you're (supposed to be) on
   // the same thread!
   bool HasCompletedMatching() const;
 
   // Returns true if the observed form has both the current and new password
   // fields, and the username field was not explicitly marked with
-  // autocomplete=username. In these cases it is not clear whether the username
-  // field is the right guess (often such change password forms do not contain
-  // the username at all), and the user should not be bothered with saving a
-  // potentially malformed credential. Once we handle change password forms
-  // correctly, or http://crbug.com/448351 gets implemented, this method should
-  // be replaced accordingly.
-  bool IsIgnorableChangePasswordForm() const;
+  // "autocomplete=username" and the user-typed username and current password
+  // field values do not match the credentials already stored. In these cases it
+  // is not clear whether the username field is the right guess (often such
+  // change password forms do not contain the username at all), and the user
+  // should not be bothered with saving a potentially malformed credential. Once
+  // we handle change password forms correctly, this method should be replaced
+  // accordingly.
+  bool IsIgnorableChangePasswordForm(
+      const base::string16& typed_username,
+      const base::string16& typed_password) const;
 
   // Determines if the user opted to 'never remember' passwords for this form.
   bool IsBlacklisted() const;
 
   // Used by PasswordManager to determine whether or not to display
   // a SavePasswordBar when given the green light to save the PasswordForm
   // managed by this.
   bool IsNewLogin() const;
 
   // Returns true if the current pending credentials were found using
@@ skipping 250 matching lines @@
   ManagerAction manager_action_;
   UserAction user_action_;
   SubmitResult submit_result_;
 
   DISALLOW_COPY_AND_ASSIGN(PasswordFormManager);
 };
 
 }  // namespace password_manager
 
 #endif  // COMPONENTS_PASSWORD_MANAGER_CORE_BROWSER_PASSWORD_FORM_MANAGER_H_