Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: components/autofill/core/common/save_password_progress_logger.h

Issue 870513002: [PasswordManager] Improve detection of ignorable change password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated reviews. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
115 STRING_NO_STORE, 115 STRING_NO_STORE,
116 STRING_CREATE_LOGIN_MANAGERS_METHOD, 116 STRING_CREATE_LOGIN_MANAGERS_METHOD,
117 STRING_OLD_NUMBER_LOGIN_MANAGERS, 117 STRING_OLD_NUMBER_LOGIN_MANAGERS,
118 STRING_NEW_NUMBER_LOGIN_MANAGERS, 118 STRING_NEW_NUMBER_LOGIN_MANAGERS,
119 STRING_ENABLED_FOR_CURRENT_PAGE_METHOD, 119 STRING_ENABLED_FOR_CURRENT_PAGE_METHOD,
120 STRING_CLIENT_CHECK_PRESENT, 120 STRING_CLIENT_CHECK_PRESENT,
121 STRING_SHOW_LOGIN_PROMPT_METHOD, 121 STRING_SHOW_LOGIN_PROMPT_METHOD,
122 STRING_NEW_UI_STATE, 122 STRING_NEW_UI_STATE,
123 STRING_FORM_NOT_AUTOFILLED, 123 STRING_FORM_NOT_AUTOFILLED,
124 STRING_CHANGE_PASSWORD_FORM, 124 STRING_CHANGE_PASSWORD_FORM,
125 PROCESS_FRAME_METHOD,
125 STRING_INVALID, // Represents a string returned in a case of an error. 126 STRING_INVALID, // Represents a string returned in a case of an error.
126 STRING_MAX = STRING_INVALID 127 STRING_MAX = STRING_INVALID
127 }; 128 };
128 129
129 SavePasswordProgressLogger(); 130 SavePasswordProgressLogger();
130 virtual ~SavePasswordProgressLogger(); 131 virtual ~SavePasswordProgressLogger();
131 132
132 // Call these methods to log information. They sanitize the input and call 133 // Call these methods to log information. They sanitize the input and call
133 // SendLog to pass it for display. 134 // SendLog to pass it for display.
134 void LogPasswordForm(StringID label, const PasswordForm& form); 135 void LogPasswordForm(StringID label, const PasswordForm& form);
(...skipping 13 matching lines...) Expand all
148 private: 149 private:
149 // Converts |log| and its |label| to a string and calls SendLog on the result. 150 // Converts |log| and its |label| to a string and calls SendLog on the result.
150 void LogValue(StringID label, const base::Value& log); 151 void LogValue(StringID label, const base::Value& log);
151 152
152 DISALLOW_COPY_AND_ASSIGN(SavePasswordProgressLogger); 153 DISALLOW_COPY_AND_ASSIGN(SavePasswordProgressLogger);
153 }; 154 };
154 155
155 } // namespace autofill 156 } // namespace autofill
156 157
157 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_ 158 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_SAVE_PASSWORD_PROGRESS_LOGGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/common/save_password_progress_logger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698