Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 870453002: Make the scripting OOP PDF API easier to use (take 2) (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the scripting OOP PDF API easier to use (take 2) This mainly removes the need to call setParentWindow before using the API but it also delays more messages from being received until the document is loaded which makes the API easier to use. BUG=415858 Committed: https://crrev.com/c121c2269073e9249c982d9ba7c3301cb6e778a7 Cr-Commit-Position: refs/heads/master@{#312722}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -60 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 4 chunks +45 lines, -22 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 4 chunks +12 lines, -12 lines 0 comments Download
M pdf/out_of_process_instance.h View 1 chunk +0 lines, -4 lines 0 comments Download
M pdf/out_of_process_instance.cc View 3 chunks +14 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
raymes
5 years, 11 months ago (2015-01-22 04:10:58 UTC) #2
Sam McNally
lgtm https://codereview.chromium.org/870453002/diff/20001/chrome/browser/resources/pdf/pdf.js File chrome/browser/resources/pdf/pdf.js (right): https://codereview.chromium.org/870453002/diff/20001/chrome/browser/resources/pdf/pdf.js#newcode639 chrome/browser/resources/pdf/pdf.js:639: case 'loadPreviewPage': Isn't this used for print preview?
5 years, 11 months ago (2015-01-22 06:12:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870453002/40001
5 years, 11 months ago (2015-01-22 22:25:06 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
5 years, 11 months ago (2015-01-23 00:28:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870453002/40001
5 years, 11 months ago (2015-01-23 00:30:33 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-23 01:15:17 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-23 01:15:53 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c121c2269073e9249c982d9ba7c3301cb6e778a7
Cr-Commit-Position: refs/heads/master@{#312722}

Powered by Google App Engine
This is Rietveld 408576698