Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 870413005: Add more GURLTest.Resolve examples for clarity. (Closed)

Created:
5 years, 11 months ago by maxbogue
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more GURLTest.Resolve examples for clarity. I was confused about how this worked when writing http://crrev.com/864993002 and none of the existing examples clarified it. Is there a utility method that will just always append to the path? like "a.com/b" and "c" makes "a.com/b/c"? Committed: https://crrev.com/ac0afb8657e49b1f792bd19d6f0acf805c28f49a Cr-Commit-Position: refs/heads/master@{#313216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M url/gurl_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
maxbogue
5 years, 11 months ago (2015-01-26 19:42:08 UTC) #2
abarth-chromium
lgtm
5 years, 11 months ago (2015-01-27 01:28:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/870413005/1
5 years, 11 months ago (2015-01-27 03:08:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 03:11:20 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 03:12:37 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac0afb8657e49b1f792bd19d6f0acf805c28f49a
Cr-Commit-Position: refs/heads/master@{#313216}

Powered by Google App Engine
This is Rietveld 408576698