Issue 870413002: Remove PlatformEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 870413002: Remove PlatformEvent (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
eseidel1

CC:
esprehn, eseidel, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove PlatformEvent There aren't any more subclasses or uses. Also, remove PlatformEventController and PlatformEventDispatcher, which are also dead code. R=eseidel@google.com Committed: https://chromium.googlesource.com/external/mojo/+/94eb87ebc4fc473d467bfbaa63d8496f6f82cffc

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -422 lines)			Patch
M	sky/engine/core/core.gni	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/Document.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/Document.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/frame/NewEventHandler.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/core/frame/PlatformEventController.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	sky/engine/core/frame/PlatformEventController.cpp	View	1 chunk	+0 lines, -70 lines	0 comments	Download
D	sky/engine/core/frame/PlatformEventDispatcher.h	View	1 chunk	+0 lines, -37 lines	0 comments	Download
D	sky/engine/core/frame/PlatformEventDispatcher.cpp	View	1 chunk	+0 lines, -87 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	sky/engine/core/page/EventHandler.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/core/page/EventWithHitTestResults.h	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	sky/engine/core/rendering/RenderLayerScrollableArea.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/platform/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	sky/engine/platform/PlatformEvent.h	View	1 chunk	+0 lines, -105 lines	0 comments	Download
M	sky/engine/web/WebViewImpl.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

abarth-chromium

5 years, 11 months ago (2015-01-26 07:48:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
94eb87ebc4fc473d467bfbaa63d8496f6f82cffc (presubmit successful).