Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 870393002: Remove GraphicsContext annotations. (Closed)

Created:
5 years, 11 months ago by ojan
Modified:
5 years, 11 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove GraphicsContext annotations. It's all dead code. This is a first step towards getting rid of paint phases. Also delete some related dead classes. TBR=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/f25f897e44b47617f4be40352c4fced35a8d2936

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -742 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/rendering/GraphicsContextAnnotator.h View 1 chunk +0 lines, -68 lines 0 comments Download
D sky/engine/core/rendering/GraphicsContextAnnotator.cpp View 1 chunk +0 lines, -135 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/platform/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.h View 4 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/platform/graphics/GraphicsContext.cpp View 3 chunks +0 lines, -32 lines 0 comments Download
D sky/engine/platform/graphics/GraphicsContextAnnotation.h View 1 chunk +0 lines, -55 lines 0 comments Download
D sky/engine/platform/graphics/InterceptingCanvas.h View 1 chunk +0 lines, -82 lines 0 comments Download
D sky/engine/platform/graphics/OpaqueRectTrackingContentLayerDelegate.h View 1 chunk +0 lines, -69 lines 0 comments Download
D sky/engine/platform/graphics/OpaqueRectTrackingContentLayerDelegate.cpp View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/platform/graphics/OpaqueRectTrackingContentLayerDelegateTest.cpp View 1 chunk +0 lines, -195 lines 0 comments Download
M sky/engine/web/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (1 generated)
ojan
Committed patchset #1 (id:1) manually as f25f897e44b47617f4be40352c4fced35a8d2936 (presubmit successful).
5 years, 11 months ago (2015-01-26 03:52:34 UTC) #1
abarth-chromium
5 years, 11 months ago (2015-01-26 06:44:27 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698