Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: cc/trees/layer_tree_host.cc

Issue 870363005: Remove scroll_delta flooring hack (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host_client.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 The Chromium Authors. All rights reserved. 1 // Copyright 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/trees/layer_tree_host.h" 5 #include "cc/trees/layer_tree_host.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <stack> 8 #include <stack>
9 #include <string> 9 #include <string>
10 10
(...skipping 25 matching lines...) Expand all
36 #include "cc/scheduler/begin_frame_source.h" 36 #include "cc/scheduler/begin_frame_source.h"
37 #include "cc/trees/layer_tree_host_client.h" 37 #include "cc/trees/layer_tree_host_client.h"
38 #include "cc/trees/layer_tree_host_common.h" 38 #include "cc/trees/layer_tree_host_common.h"
39 #include "cc/trees/layer_tree_host_impl.h" 39 #include "cc/trees/layer_tree_host_impl.h"
40 #include "cc/trees/layer_tree_impl.h" 40 #include "cc/trees/layer_tree_impl.h"
41 #include "cc/trees/occlusion_tracker.h" 41 #include "cc/trees/occlusion_tracker.h"
42 #include "cc/trees/single_thread_proxy.h" 42 #include "cc/trees/single_thread_proxy.h"
43 #include "cc/trees/thread_proxy.h" 43 #include "cc/trees/thread_proxy.h"
44 #include "cc/trees/tree_synchronizer.h" 44 #include "cc/trees/tree_synchronizer.h"
45 #include "ui/gfx/geometry/size_conversions.h" 45 #include "ui/gfx/geometry/size_conversions.h"
46 #include "ui/gfx/geometry/vector2d_conversions.h"
46 47
47 namespace { 48 namespace {
48 static base::StaticAtomicSequenceNumber s_layer_tree_host_sequence_number; 49 static base::StaticAtomicSequenceNumber s_layer_tree_host_sequence_number;
49 } 50 }
50 51
51 namespace cc { 52 namespace cc {
52 53
53 RendererCapabilities::RendererCapabilities(ResourceFormat best_texture_format, 54 RendererCapabilities::RendererCapabilities(ResourceFormat best_texture_format,
54 bool allow_partial_texture_updates, 55 bool allow_partial_texture_updates,
55 int max_texture_size, 56 int max_texture_size,
(...skipping 1030 matching lines...) Expand 10 before | Expand all | Expand 10 after
1086 ScopedPtrVector<SwapPromise>::iterator it = info->swap_promises.begin(); 1087 ScopedPtrVector<SwapPromise>::iterator it = info->swap_promises.begin();
1087 for (; it != info->swap_promises.end(); ++it) { 1088 for (; it != info->swap_promises.end(); ++it) {
1088 scoped_ptr<SwapPromise> swap_promise(info->swap_promises.take(it)); 1089 scoped_ptr<SwapPromise> swap_promise(info->swap_promises.take(it));
1089 TRACE_EVENT_FLOW_STEP0("input", 1090 TRACE_EVENT_FLOW_STEP0("input",
1090 "LatencyInfo.Flow", 1091 "LatencyInfo.Flow",
1091 TRACE_ID_DONT_MANGLE(swap_promise->TraceId()), 1092 TRACE_ID_DONT_MANGLE(swap_promise->TraceId()),
1092 "Main thread scroll update"); 1093 "Main thread scroll update");
1093 QueueSwapPromise(swap_promise.Pass()); 1094 QueueSwapPromise(swap_promise.Pass());
1094 } 1095 }
1095 1096
1096 gfx::Vector2d inner_viewport_scroll_delta; 1097 gfx::Vector2dF inner_viewport_scroll_delta;
1097 gfx::Vector2d outer_viewport_scroll_delta; 1098 gfx::Vector2dF outer_viewport_scroll_delta;
1098 1099
1099 if (root_layer_.get()) { 1100 if (root_layer_.get()) {
1100 for (size_t i = 0; i < info->scrolls.size(); ++i) { 1101 for (size_t i = 0; i < info->scrolls.size(); ++i) {
1101 Layer* layer = LayerTreeHostCommon::FindLayerInSubtree( 1102 Layer* layer = LayerTreeHostCommon::FindLayerInSubtree(
1102 root_layer_.get(), info->scrolls[i].layer_id); 1103 root_layer_.get(), info->scrolls[i].layer_id);
1103 if (!layer) 1104 if (!layer)
1104 continue; 1105 continue;
1105 if (layer == outer_viewport_scroll_layer_.get()) { 1106 if (layer == outer_viewport_scroll_layer_.get()) {
1106 outer_viewport_scroll_delta += info->scrolls[i].scroll_delta; 1107 outer_viewport_scroll_delta += info->scrolls[i].scroll_delta;
1107 } else if (layer == inner_viewport_scroll_layer_.get()) { 1108 } else if (layer == inner_viewport_scroll_layer_.get()) {
(...skipping 22 matching lines...) Expand all
1130 if (outer_viewport_scroll_layer_.get()) { 1131 if (outer_viewport_scroll_layer_.get()) {
1131 outer_viewport_scroll_layer_->SetScrollOffsetFromImplSide( 1132 outer_viewport_scroll_layer_->SetScrollOffsetFromImplSide(
1132 gfx::ScrollOffsetWithDelta( 1133 gfx::ScrollOffsetWithDelta(
1133 outer_viewport_scroll_layer_->scroll_offset(), 1134 outer_viewport_scroll_layer_->scroll_offset(),
1134 outer_viewport_scroll_delta)); 1135 outer_viewport_scroll_delta));
1135 } 1136 }
1136 1137
1137 ApplyPageScaleDeltaFromImplSide(info->page_scale_delta); 1138 ApplyPageScaleDeltaFromImplSide(info->page_scale_delta);
1138 elastic_overscroll_ += info->elastic_overscroll_delta; 1139 elastic_overscroll_ += info->elastic_overscroll_delta;
1139 if (!settings_.use_pinch_virtual_viewport) { 1140 if (!settings_.use_pinch_virtual_viewport) {
1141 // TODO(miletus): Make sure either this code path is totally gone,
1142 // or revisit the flooring here if the old pinch viewport code path
1143 // is causing problems with fractional scroll offset.
1140 client_->ApplyViewportDeltas( 1144 client_->ApplyViewportDeltas(
1141 inner_viewport_scroll_delta + outer_viewport_scroll_delta, 1145 gfx::ToFlooredVector2d(inner_viewport_scroll_delta +
1142 info->page_scale_delta, 1146 outer_viewport_scroll_delta),
1143 info->top_controls_delta); 1147 info->page_scale_delta, info->top_controls_delta);
1144 } else { 1148 } else {
1145 // TODO(ccameron): pass the elastic overscroll here so that input events 1149 // TODO(ccameron): pass the elastic overscroll here so that input events
1146 // may be translated appropriately. 1150 // may be translated appropriately.
1147 client_->ApplyViewportDeltas( 1151 client_->ApplyViewportDeltas(
1148 inner_viewport_scroll_delta, outer_viewport_scroll_delta, 1152 inner_viewport_scroll_delta, outer_viewport_scroll_delta,
1149 info->elastic_overscroll_delta, info->page_scale_delta, 1153 info->elastic_overscroll_delta, info->page_scale_delta,
1150 info->top_controls_delta); 1154 info->top_controls_delta);
1151 } 1155 }
1152 } 1156 }
1153 } 1157 }
(...skipping 222 matching lines...) Expand 10 before | Expand all | Expand 10 after
1376 bool children_need_begin_frames) const { 1380 bool children_need_begin_frames) const {
1377 proxy_->SetChildrenNeedBeginFrames(children_need_begin_frames); 1381 proxy_->SetChildrenNeedBeginFrames(children_need_begin_frames);
1378 } 1382 }
1379 1383
1380 void LayerTreeHost::SendBeginFramesToChildren( 1384 void LayerTreeHost::SendBeginFramesToChildren(
1381 const BeginFrameArgs& args) const { 1385 const BeginFrameArgs& args) const {
1382 client_->SendBeginFramesToChildren(args); 1386 client_->SendBeginFramesToChildren(args);
1383 } 1387 }
1384 1388
1385 } // namespace cc 1389 } // namespace cc
OLDNEW
« no previous file with comments | « cc/test/layer_tree_test.cc ('k') | cc/trees/layer_tree_host_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698